Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen 131]: add emitUnionProp in parser primitives #38705

Closed
wants to merge 1 commit into from
Closed

[Codegen 131]: add emitUnionProp in parser primitives #38705

wants to merge 1 commit into from

Conversation

Zwem
Copy link
Contributor

@Zwem Zwem commented Jul 31, 2023

Summary:

[Codegen 131] This PR add a function emitUnionProp to the parser-primitives, as requested on #34872

Changelog:

[INTERNAL] [ADDED] - Add emitUnionProp function to parser-primitives

Test Plan:

yarn test react-native-codegen

@Zwem
refactor(codegen): add emitUnionProp in parser primitives
16f4d9b 
Signed-off-by: Denis <denis.vasilyeu@gmail.com>
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 31, 2023
@Zwem
Copy link
Contributor Author

Zwem commented Jul 31, 2023

@rshest Hi, sorry, but the previous PR was closed because of branch name changing(#38704)

@rshest
Copy link
Contributor

rshest commented Jul 31, 2023

@Zwem Sorry, I am a bit confused to what exactly had happened. Why was #38704 closed?

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Zwem
Copy link
Contributor Author

Zwem commented Jul 31, 2023

@rshest After creating PR I found this alert "The head ref may contain hidden characters: "\u0441odegen-131" because, in the named branch, I had the Cyrillic symbol 'с' instead of Latin 'c'. And after I renamed brunch in the proper way PR was closed.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,885,453 +2
android hermes armeabi-v7a 7,935,800 +0
android hermes x86 9,281,970 +1
android hermes x86_64 9,185,458 -1
android jsc arm64-v8a 9,473,451 -2
android jsc armeabi-v7a 8,416,807 -2
android jsc x86 9,456,195 -1
android jsc x86_64 9,772,408 -1

Base commit: 8bcfc49
Branch: main

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This pull request was successfully merged by @Zwem in 5eaf28b.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 1, 2023
@Zwem Zwem deleted the codegen-131 branch August 1, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zwem @rshest @facebook-github-bot @analysis-bot